Skip to content

Conversation

@dhasani23
Copy link
Contributor

Problem

We should perform builds client-side (rather than server-side) to handle customers’ unique / challenging local environments, which often cause our server-side build to fail.

Solution

Periodically download intermediate diff.patch files, apply them to a copy of the project, perform the local build, then upload the build logs and resume the transformation.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners March 12, 2025 00:38
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@dhasani23 dhasani23 marked this pull request as draft March 12, 2025 00:59
@justinmk3
Copy link
Contributor

The clear Problem/Solution description here is great!

@dhasani23
Copy link
Contributor Author

dhasani23 commented Apr 11, 2025

TODO: add change log entry

EDIT: will merge behind a feature flag first, then add a change log entry in a future PR just before releasing

}

// TO-DO: remove when releasing CSB
export const isClientSideBuildEnabled = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll notice there are a good amount of TO-DOs in this PR — the intention is to merge this feature behind a feature flag (this one), and simply enable everything in a future PR, once we are ready to release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tracking all TO-DOs to ensure when we release they are all addressed

@dhasani23 dhasani23 marked this pull request as ready for review April 24, 2025 20:34
@dhasani23
Copy link
Contributor Author

/runIntegrationTests

@justinmk3 justinmk3 merged commit 0651afd into aws:master Apr 30, 2025
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants